adds admin notification #106
Conversation
| [ADMIN] | ||
| ;;; Benachrichtigungsweg für Fehlermeldungen an den Admin: | ||
| ;;; 'email', 'telegram', [...] oder 'none', wenn keine separaten Fehlermeldungen gesendet werden sollen | ||
| method=none |
There was a problem hiding this comment.
@sibalzer my proposal to avoid a huge config.ini or cluttering the directory with a second config file
There was a problem hiding this comment.
i still have to think about it. it would make sense to have three variables where you can specify either a mail address telegram id or apprise uri where a notification can be sent to. I would write this only in the documentation to not create confusion.
e.g.
[ADMIN]
notification_telegram_id=
notification_email_adress=
notification_aprrise_uri=There was a problem hiding this comment.
btw i dont think we need a beta or dev branch anymore. with v3 this was still necessary because there were massive feature addings and i made big changes with settings.py in parallel. i just couldn't handle all the manual testing. but that changed and we have a ci pipeline with linting, unittesting and integration tests. we can be more agile now.
There was a problem hiding this comment.
Your proposal looks great, I like it. I was also thinking about it, but apparently not far enough.
So do you want to merge new feature branches directly onto main now? I wasn't sure, but if you say it should be fine, we can do that of course. I think it's a choice of release frequency, isn't it? (i. e. release smaller updates more often v. bigger updates less frequently)
There was a problem hiding this comment.
We should approach it that way. But I don't have time at the moment (exams), so no pressure.
No description provided.