fixes for non-strictly sequential behavior in JSON fields #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as of MySQL 8.0.16, there are cases (see zendesk/maxwell#1290) in which MySQL places JSON binary data at the offset specified in the header instead of just laying it out in order.
|
ping |
1 similar comment
|
ping |
|
might be the same as #302 ; shyko, you in the land of the living? |
|
(@shyiko) |
|
@shyiko, if you ain't got the time, mind if I do some maintainership? I promise not to break everything all at the same time |
This was referenced Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of MySQL 8.0.16, there are cases (see zendesk/maxwell#1290) in which MySQL places JSON binary data at the offset specified in the header instead of just laying it out in order. It leaves junk data in between string fields, presumably there's some deep buffer-copy-something going on under the good.
@shyiko I could write a test for this case but we'd have to bring up a 8.0.16 virtualbox or else it just won't repro....