[ADD] Rock-paper-scissor game #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shsa-odoo
reviewed
Feb 10, 2023
Comment on lines
+22
to
+26
| var a = this.computer_choice(); | ||
| let b = this.choice; | ||
| let c = Number(document.getElementById('computer_score').textContent); | ||
| let u = Number(document.getElementById('user_score').textContent); | ||
| let n = Number(document.getElementById('points').value); |
There was a problem hiding this comment.
use better naming conventions, representing the property of value assingned.
shsa-odoo
reviewed
Feb 10, 2023
Comment on lines
+28
to
+65
| if (n) { | ||
| document.getElementById('computer_img').src = `img/${a}.png` | ||
| document.getElementById('user_img').src = `img/${b}.png` | ||
| if ((a == "rock" & b == "scissor") | (a == "scissor" & b == "paper") | (a == "paper" & b == "rock")) { | ||
| document.getElementById('computer_score').innerHTML = c += 1; | ||
| document.getElementById('score').innerHTML = "Computer Wins"; | ||
| } | ||
| else if ((b == "rock" & a == "scissor") | (b == "scissor" & a == "paper") | (b == "paper" & a == "rock")) { | ||
| document.getElementById('user_score').innerHTML = u += 1; | ||
| document.getElementById('score').innerHTML = "User Wins"; | ||
| } else { | ||
| document.getElementById('score').innerHTML = "Tie"; | ||
| } | ||
| } | ||
|
|
||
| if (n == c) { | ||
| const buttons = document.getElementsByClassName("btn"); | ||
| for (let i = 0; i < buttons.length; i++) { | ||
| buttons[i].disabled = true; | ||
| } | ||
| document.getElementById("computer_header").classList.add("bg-success"); | ||
| document.getElementById("computer_body").classList.add("border-success"); | ||
| document.getElementById("user_header").classList.add("bg-danger"); | ||
| document.getElementById("user_body").classList.add("border-danger"); | ||
| } | ||
| else if (n == u) { | ||
| const buttons = document.getElementsByClassName("btn"); | ||
| for (let i = 0; i < buttons.length; i++) { | ||
| buttons[i].disabled = true; | ||
| } | ||
| document.getElementById("user_header").classList.add("bg-success"); | ||
| document.getElementById("user_body").classList.add("border-success"); | ||
| document.getElementById("computer_header").classList.add("bg-danger"); | ||
| document.getElementById("computer_body").classList.add("border-danger"); | ||
|
|
||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
update this code using ternary operator, avoid using multiple if..else and repeating statements,
what i can see is there are only three cases when user can win:
you_win = ( (you === "rock") && (opponent === "scissor") ||
(you === "paper") && (opponent === "rock") ||
(you === "scissor") && (opponent === "rock") ) // returns true for your win cases only.
.
.
so (you === opponent) ? "draw message" : you_win ? call a method for updating score and message for user : call method for updating score and message for computer;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.