Skip to content

Commit

Permalink
Merge pull request #44 from m-jahn/dev
Browse files Browse the repository at this point in the history
fix: example run time exceeded for 2 geoms
  • Loading branch information
showteeth authored Jan 17, 2025
2 parents 9959cb7 + af333e4 commit 8465fd8
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 8 deletions.
2 changes: 1 addition & 1 deletion R/geom_cnv.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#' @export
#'
#' @examples
#' if (requireNamespace("BSgenome.Hsapiens.UCSC.hg19", quietly = TRUE)) {
#' \dontrun{
#' library("BSgenome.Hsapiens.UCSC.hg19")
#'
#' # load track data
Expand Down
2 changes: 1 addition & 1 deletion R/geom_gc.R
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#' @export
#'
#' @examples
#' if (requireNamespace("BSgenome.Hsapiens.UCSC.hg19", quietly = TRUE)) {
#' \dontrun{
#' library("BSgenome.Hsapiens.UCSC.hg19")
#'
#' # load track data
Expand Down
18 changes: 14 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
# Resubmission

Update for current submission: We have substantially removed the size of test
files for the examples, reducing overall package size from ~30 Mb to only ~6 Mb.
A further reduction was not possible as the package contains examples for
many different NGS file types.
Update for current submission:

- We have substantially removed the size of test files for the examples,
reducing overall package size from ~30 Mb to only ~6 Mb. A further reduction
was not possible as the package contains examples for many different NGS file
types.

- Examples were reduced to run in shorter time or excluded from running at all.
Please note that the 5 sec threshold feels very arbitrary and heavily depends
on the test environment -- this package never exceeds the threshold when
tested locally on a 3 year old average laptop, or in 3 different github actions
workflows, but regularly fails on the CRAN server.

Background information:

This package has been submitted previously (2023, v0.7.1) and was removed from
CRAN due to several issues. In the mean time many functions were re-factored,
Expand Down
2 changes: 1 addition & 1 deletion man/geom_cnv.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/geom_gc.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8465fd8

Please sign in to comment.