SG-419020 Fix ruamel module missing __init__.py file#1087
Open
carlos-villavicencio-adsk wants to merge 3 commits intomasterfrom
Open
SG-419020 Fix ruamel module missing __init__.py file#1087carlos-villavicencio-adsk wants to merge 3 commits intomasterfrom
carlos-villavicencio-adsk wants to merge 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 79.65% 79.63% -0.02%
==========================================
Files 198 198
Lines 20620 20624 +4
==========================================
Hits 16424 16424
- Misses 4196 4200 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eduardoChaucaGallegos
approved these changes
Feb 11, 2026
carlos-villavicencio-adsk
requested review from
eduardoChaucaGallegos and
julien-lang
julien-lang
reviewed
Feb 19, 2026
Member
There was a problem hiding this comment.
Why is there a change on this file??
Contributor
Author
There was a problem hiding this comment.
This file didn't exist.
Comment on lines
+222
to
+227
| try: | ||
| version_a = version_parse(a) | ||
| version_b = version_parse(b) | ||
| except InvalidVersion: | ||
| # If the version is invalid by `packaging.version.parse`, compare lexicographically | ||
| return a > b |
Member
There was a problem hiding this comment.
can we have a log or a warning in those cases?
Contributor
Author
There was a problem hiding this comment.
I don't think it's a good idea. See #1056
eduardoChaucaGallegos
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue appears to be related to the following change where the folder ruamel_yaml was changed to ruamel/yaml without an
__init__.pybeing added2482c47
Another fix
On #1066 we bundled
packaging.version.parsebut removed support for any shape of string to be compared, causing crashes when passing values such asunknown.