Skip to content

esp: don't busy-spin the MIDI task when the FreeRTOS tick is 100 Hz #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwhitman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

esp: don't busy-spin the MIDI task when the FreeRTOS tick is 100 Hz #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/amy_midi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,14 @@ void esp_deinit_midi(void) {
void esp_poll_midi(void) {
const int uart_num = esp_get_uart(amy_global.config.midi_uart);
uint8_t data[MAX_MIDI_BYTES_TO_PARSE];
int length = uart_read_bytes(uart_num, data, MAX_MIDI_BYTES_TO_PARSE /*MAX_MIDI_BYTES_PER_MESSAGE*MIDI_QUEUE_DEPTH*/, 1/portTICK_PERIOD_MS);
// Block for at least one tick. The old 1/portTICK_PERIOD_MS is
// integer-zero whenever the tick is slower than 1ms (e.g. ESP-IDF's
// and MicroPython's default CONFIG_FREERTOS_HZ=100), which made this
// a zero-timeout read and run_midi_task() a busy-spin pinning its
// core at 100% from a priority-23 task.
TickType_t timeout = pdMS_TO_TICKS(1);
if (timeout == 0) timeout = 1;
int length = uart_read_bytes(uart_num, data, MAX_MIDI_BYTES_TO_PARSE /*MAX_MIDI_BYTES_PER_MESSAGE*MIDI_QUEUE_DEPTH*/, timeout);
if(length > 0) {
convert_midi_bytes_to_messages(data,length,0);
}
Expand Down
Loading