tulipcc-pin: fold the refreshed refdocs/amy snapshot into the bump commit#957
Merged
Conversation
Every auto-opened tulipcc pin PR was starting red on tulipcc's refdocs-fresh check: moving the amy gitlink stales tulip/server/refdocs/amy/_VENDORED_FROM.txt (it stamps the source SHA), and the workflow never regenerated the snapshot. Add a step that clones shorepine/tulipcc@main (trusted -- never this PR's code), runs its sync_amy_docs.py --sha <merged-sha> (falls back to GitHub raw for doc content), and hands the changed files to the Git Data API step, which now includes them as blobs (or deletions) in the same tree as the gitlink bump. Best-effort: any failure (e.g. a tulipcc@main script without --sha yet) leaves the changes list empty and the pin PR opens exactly as before. Companion tulipcc PR adds the --sha flag to sync_amy_docs.py. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
⛓️ tulipcc integration PR openedThis merge was pinned into tulipcc for full-system CI: shorepine/tulipcc#1217 Test it there and merge that PR to move tulipcc onto this AMY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every auto-opened tulipcc pin PR starts red on tulipcc's
refdocs-freshcheck (e.g. shorepine/tulipcc#1215): moving theamygitlink stalestulip/server/refdocs/amy/_VENDORED_FROM.txt— it stamps the source SHA — and this workflow never regenerated the snapshot, so a human had to push a fix-up commit to every pin PR.Fix
New step between gather and pin:
pull_request_targetsafety note in the header holds) and runs itstulip/server/sync_amy_docs.py --sha <merged-sha>. With no submodule in the shallow clone, the script sources doc content from GitHub raw at that SHA.git diff --cached --name-statuslist; the Git Data API step now includes them in the bump commit's tree as inline blobs (orsha: nulldeletions) alongside the gitlink.--sha) leaves the list empty and the pin PR opens exactly as today — merge order between this and the companion tulipcc PR doesn't matter.Companion tulipcc PR (adds the
--shaflag): shorepine/tulipcc#1216Testing
🤖 Generated with Claude Code