Skip to content

Remove 'r'/'voices=', do not expose explicit voice selection to API.#943

Merged
dpwe merged 5 commits into
mainfrom
deprecate_r
Jul 19, 2026
Merged

Remove 'r'/'voices=', do not expose explicit voice selection to API.#943
dpwe merged 5 commits into
mainfrom
deprecate_r

Conversation

@dpwe

@dpwe dpwe commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Before we added synth=, we used voices= to configure a block of oscs, and to modify several such blocks in parallel. synth still uses the internal voices concept, but now we have removed the possibility to use it externally, which was very limited since you never knew which voice was which. If you want a voice, set up a synth with num_voices=1.

@dpwe dpwe changed the title Remove 'r'/'voices=', do not expose explicit voice control to API. Remove 'r'/'voices=', do not expose explicit voice selection to API. Jul 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎛️ AMY HW CI (AMYboard bench)

Flashed this PR's AMY (LoadTestChord: 6-voice Juno patch=1, one held note every 2 s) onto the physical AMYboard and measured the smoothed render load as the chord grows — back-to-back with the same sketch built at the PR's merge base, so Δ is this PR's own cost.

PASS — the bench ran the test to completion.

notes held main @ bc13ff9 this PR Δ
1 1467 1472 +5
2 1664 1660 -4
3 2337 2329 -8
4 2547 2544 -3
5 3276 3275 -1
6 3492 3498 +6

Full chord settled render μs: 3500 (was 3498, Δ +0.1%) (peak 3508, 39 samples)

⬇️ Artifacts: serial log · load trace · report

Self-hosted bench (amyboardci). FAIL means only that the test could not run — the load values are informational, with no threshold and no audio compare. See tools/arduino_loadsweep/.

@dpwe dpwe mentioned this pull request Jul 19, 2026
@dpwe
dpwe merged commit 85437fa into main Jul 19, 2026
11 checks passed
@bwhitman

Copy link
Copy Markdown
Collaborator

⛓️ tulipcc integration PR opened

This merge was pinned into tulipcc for full-system CI: shorepine/tulipcc#1203

Test it there and merge that PR to move tulipcc onto this AMY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants