Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-embed Icon kit @ DevHub #57

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Re-embed Icon kit @ DevHub #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
978866a
feat: add scripts, change icon path
bojanrajh Feb 23, 2024
83ee216
feat: pnpm
bojanrajh Feb 23, 2024
6065010
chore: commands
bojanrajh Feb 23, 2024
f1c45d2
fix: root path
bojanrajh Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/scripts/docs-after-clone.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#! /usr/bin/env bash
set -e

[[ -z "$1" ]] && echo "Missing working directory argument" && exit 1

#echo "Installing root npm"
#pnpm -C $1 i

#echo "Running root build"
#pnpm -C $1 --filter "*/meteor-icon-kit" build

#echo "Building figma"
#pnpm -C $1 --filter "*/meteor-icon-kit" start
Comment on lines +6 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll delete the whole file because the build step is not needed anymore and we can control some stuff from the docs.yml.


echo "Copying icons"
cp -R "$1/packages/icon-kit/icons" "$1/packages/icon-kit/docs/public"

exit 0
4 changes: 4 additions & 0 deletions .github/scripts/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
build-end:
copy-additional-assets:
- public/icons/regular
- public/icons/solid
6 changes: 3 additions & 3 deletions packages/icon-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"lint:all": "npm run lint:types && npm run lint:eslint",
"lint:types": "tsc --noEmit",
"lint:eslint": "eslint ./src --ext .ts",
"docs:link": "../developer-portal/docs-cli link --src docs --dst resources/meteor-icon-kit --symlink",
"docs:copy": "../developer-portal/docs-cli link --src docs --dst resources/meteor-icon-kit",
"docs:preview": "../developer-portal/docs-cli preview"
"docs:env": "[ -d \"../../../developer-portal\" ] && ../../../developer-portal/docs-cli.cjs pull || (git clone [email protected]:shopware/developer-portal.git ../../../developer-portal && pnpm i -C ../../../developer-portal)",
"docs:link": "../../../developer-portal/docs-cli.cjs link --src docs --dst resources/meteor-icon-kit --symlink --root ../..",
"docs:preview": "../../../developer-portal/docs-cli.cjs preview"
},
"files": [
"icons"
Expand Down
Loading