feat: add developer-portal workflows #51
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
It will work once the |
bojanrajh
force-pushed
the
dx/workflows
branch
from
981e88f to
5435d13
Compare
bojanrajh
force-pushed
the
dx/workflows
branch
from
5435d13 to
66b3387
Compare
| - main | ||
|
|
||
| jobs: | ||
| create-healthcheck: |
There was a problem hiding this comment.
I would rename this workflow and job to something that tells me this job creates a preview build. I understand a healthcheck as an Rest endpoint that you ping and you get a response back that the system is running without any issues.
There was a problem hiding this comment.
This job does 3 things actually:
- create a new "check run" in current repo
- triggers full-build in
developer-portal - updates status of the "check run" from the first step based on the result of the second step
(... continuing in the next comment).
| @@ -0,0 +1,38 @@ | |||
| # This workflow is triggered from developer-portal and updates the healthcheck status in the PR. | |||
| name: Update healthcheck | |||
There was a problem hiding this comment.
Here the same as above. I would rename this to something like "Update developer portal preview"
There was a problem hiding this comment.
This workflow as well as passing the DEV_HUB_PERSONAL_ACCESS_TOKEN / PERSONAL_TOKEN secret is only needed to update the conclusion of the check run, but the workflow name is hardcoded a few lines above that.
To sum this up: naming is hard :D Let's keep them as they are for now (and miss- aligned with other repos) as I'm planning to replace all 3 workflows with a single app integration - https://github.com/shopware/devhub-github-app/blob/main/api/webhook.js
What?
3 new workflows for communicating with the DevHub:
developer-portal-healthcheck- triggers a new preview build indeveloper-portalfor every PR targetingmainbranch in this repoupdate-healthcheck- needed to update the PR status check from the previous workflow - will be replaced with a dedicated GitHub app to avoid usage of the PATdeploy-developer-portal- triggers a new production build indeveloper-portalwhenever themainbranch has changedDEV_HUB_PERSONAL_ACCESS_TOKEN- PAT, tmpWhy?
So we can automate DevHub actions.
How?
By adding a few workflows.
Testing?
Already used by
shopware/docs,shopware/frontends,shopware/release-notes.Screenshots (optional)
Anything Else?