Improve url field #500
Merged
Improve url field #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…blurring the mt-url-field
Haberkamp
force-pushed
the
improve-url-field
branch
from
a28a406 to
c17416e
Compare
Lucsy3012
approved these changes
Feb 5, 2025
alastair-simon
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the
mt-url-fieldso it no longer depends on themt-text-fieldWhy?
The text field offers way more features than the url field offers. Moreover, because this component extends from the text component it suffers from the typical issues with inheritance.
How?
I've refactored the component in a way so that it no longer depends on the mt
-text-fieldTesting?
Feel free to test the component yourself on the branch preview.
Anything Else?