Improve number field #490
Open
Improve number field #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ing the arrow up key
…ment button on a disabled input
…ment button on a disabled input
…s less than required
…e when deleting input value
…-affix in number field
Haberkamp
force-pushed
the
improve-number-field
branch
from
fff0942 to
6a8f9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR decouples the number field from the text field.
Why?
The number field is too closely coupled to the text field, suffering from the typical issues caused by inheritance common on OOP projects.
Now the components are separated from each other, changing code in the text field no longer affects the number field, reducing the surface area of bugs and improving maintainability.
How?
I've written a lot of test before making any changes, then made the changes to make sure the behaviour is still the same.
Testing?
I've written a lot of tests to make sure everything works as before.
Check out the branch preview if you want to perform manual testing.