Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Externalize api-gen commands #1698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

freb97
Copy link
Contributor

@freb97 freb97 commented Feb 14, 2025

Description

When using the api-gen package, the only possible way currently is to use it via cli. Would it be okay to externalize the generate, loadSchema and validateJson commands to allow users to integrate it into their code?

The point of this would be to allow generating the types at build time with a nuxt hook or similar, but maybe there are other cases where the methods would be useful.

Type of change

New feature (non-breaking change which adds functionality)

ToDo's

  • Documentation added/updated

Additional context

None

Signed-off-by: Frederik Bußmann <[email protected]>
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
shopware-frontends-docs ⬜️ Skipped (Inspect) Feb 14, 2025 3:08pm

@vercel vercel bot temporarily deployed to Preview – shopware-frontends-docs February 14, 2025 15:08 Inactive
Copy link

pkg-pr-new bot commented Feb 14, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1698

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1698

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1698

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1698

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1698

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1698

commit: abeada4

Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #1698 will not alter performance

Comparing freb97:main (abeada4) with main (ae521ac)

Summary

✅ 9 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant