Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-demo-store): disable isr for catch all route #1674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Feb 6, 2025

Description

due to issue #1652 we have to disable the isr for default vercel rendering mode.

filtering in SSR works as expected: https://frontends-demo-git-feat-disable-isr-f-7f52d6-shopware-frontends.vercel.app/Products/?manufacturer=cd26289d022045aa81cbe6be0d312bfd&order=name-asc

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo 🔄 Building (Inspect) Visit Preview Feb 6, 2025 2:43pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
shopware-frontends-docs ⬜️ Skipped (Inspect) Feb 6, 2025 2:43pm

Copy link

pkg-pr-new bot commented Feb 6, 2025

Open in Stackblitz

@shopware/api-client

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-client@1674

@shopware/cms-base-layer

npm i https://pkg.pr.new/shopware/frontends/@shopware/cms-base-layer@1674

@shopware/helpers

npm i https://pkg.pr.new/shopware/frontends/@shopware/helpers@1674

@shopware/api-gen

npm i https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1674

@shopware/composables

npm i https://pkg.pr.new/shopware/frontends/@shopware/composables@1674

@shopware/nuxt-module

npm i https://pkg.pr.new/shopware/frontends/@shopware/nuxt-module@1674

commit: f5ed511

@mdanilowicz mdanilowicz self-requested a review February 6, 2025 17:23
@patzick
Copy link
Collaborator

patzick commented Feb 11, 2025

It's fixing only listing pages with filtering, but removes a very good caching option overall

what about reloading it on CSR when query params are present?

for comparision:

page is loading over 10x slower without ISR

@patzick patzick added the question Further information is requested label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants