[14.0][IMP] shopinvader_locomotive: avoid unnecessary partner exports #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybackman
force-pushed
the
14.0-shopinvader_locomotive-avoid_unnecessary_partner_exports
branch
4 times, most recently
from
bc97da5 to
95b102a
Compare
mmequignon
suggested changes
Jan 20, 2025
| @skip_if(lambda self, record, **kwargs: self.no_connector_export(record)) | ||
| def on_record_write(self, record, fields=None): | ||
| # skip export if updating only fields that are not relevant | ||
| if set(fields).issubset(set(self._get_export_not_triggered_fields())): |
There was a problem hiding this comment.
Could this be an issue?
>>> set(None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'NoneType' object is not iterableI would check if fields is set first, and _get_export_not_triggered_fields, because it can be overridden to return None or False depending on a company setting in the future, for instance.
There was a problem hiding this comment.
Great points. Made modifications and added tests to cover the mentioned scenarios
henrybackman
force-pushed
the
14.0-shopinvader_locomotive-avoid_unnecessary_partner_exports
branch
from
95b102a to
8d1fa38
Compare
mmequignon
reviewed
Jan 21, 2025
Comment on lines
148
to
153
| with patch( | ||
| "odoo.addons.shopinvader_locomotive.component.event_listeners.ShopinvaderBindingListener._get_export_not_triggered_fields", | ||
| mock_get_export_not_triggered_fields, | ||
| ): |
There was a problem hiding this comment.
Is pre-commit happy about that?
Suggested change
| with patch( | |
| "odoo.addons.shopinvader_locomotive.component.event_listeners.ShopinvaderBindingListener._get_export_not_triggered_fields", | |
| mock_get_export_not_triggered_fields, | |
| ): | |
| method_path = ( | |
| "odoo.addons.shopinvader_locomotive.component.event_listeners." | |
| "ShopinvaderBindingListener._get_export_not_triggered_fields" | |
| ) | |
| with patch(method_path, mock_get_export_not_triggered_fields): |
There was a problem hiding this comment.
pre-commit issues fixed and changes pass them now
henrybackman
force-pushed
the
14.0-shopinvader_locomotive-avoid_unnecessary_partner_exports
branch
from
8d1fa38 to
00afd15
Compare
henrybackman
force-pushed
the
14.0-shopinvader_locomotive-avoid_unnecessary_partner_exports
branch
from
00afd15 to
5c44d63
Compare
simahawk
approved these changes
Jan 22, 2025
|
/ocabot merge minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shopinvader_locomotive: avoid unnecessary partner exports by not executing the export if the updated fields contain only:
external_idlast_login_time