[14.0][FIX] shopinvader track_external_mixin #1560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acsonefho
force-pushed
the
14.0-fix_shopinvader_track_external_mixin
branch
from
6eed2de to
f4c86fb
Compare
During the creation of a model who inherites of track;external.mixin, the last_external_update_date was not set (with current datetime)
Improve the job in charge of unlink old carts by adding an identity key (to avoid having too much jobs who are doing the same cleaning on the same backend)
acsonefho
force-pushed
the
14.0-fix_shopinvader_track_external_mixin
branch
from
f4c86fb to
fe7bc00
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] During the creation of a record who inherit
track.external.mixin, thelast_external_update_datefield was not set.[IMP] Improve the job who is cleaning those carts by adding an
identity_key. That could avoid overloading queue job if something (not related to shopinvader) flood it.auto-update of
index.html(has been done automatically)