Skip to content

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jul 31, 2025

Closes #713

Espose a new ShlinkSidebarToggleButton component that can be used to customize the location of the sidebar toggle, rather than making it assume there's a header bar and position it there.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.80%. Comparing base (e1bc59e) to head (5d06103).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/sidebar/ShlinkSidebarToggleButton.tsx 88.88% 0 Missing and 3 partials ⚠️
src/Main.tsx 60.00% 0 Missing and 2 partials ⚠️
src/sidebar/ShlinkSidebarVisibilityProvider.tsx 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   79.77%   79.80%   +0.02%     
==========================================
  Files         174      176       +2     
  Lines        7985     8011      +26     
  Branches     1495     1500       +5     
==========================================
+ Hits         6370     6393      +23     
+ Misses        145      143       -2     
- Partials     1470     1475       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acelaya acelaya merged commit 8247c7c into shlinkio:main Jul 31, 2025
8 checks passed
@acelaya acelaya deleted the feature/independent-toggle branch July 31, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract sidebar toggle button into its own reusable component
1 participant