-
-
Notifications
You must be signed in to change notification settings - Fork 4
Feature: User Configured Jobs directory #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Feature: User Configured Jobs directory #12
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
@shiny will it be an issue if I add a new package to the dependencies of this lib? I have added |
Thank you for your contribution! Regarding this PR, I don't think the new dependency is necessary — fsImportAll already supports a filter method. (Just a side note: @poppinss/utils is a core AdonisJS library.) Secondly, the name jobsGlob feels a bit too geeky. Do you have a more elegant or intuitive alternative in mind? |
Thanks for the feedback here @shiny.
Let me know if you find that suitable |
@shiny kindly review now, I am now using the path instead of the using glob matching |
@shiny any update? |
We can skip glob support for now and only allow a custom directory to be specified. |
@shiny I have updated the path, can you kindly check now? |
This PR link to #11 to add user configurable path for adonis_resque