Skip to content

[codex] Surface public RSC performance demo#104

Merged
justin808 merged 2 commits into
mainfrom
jg-codex/rsc-demo-site-links
May 13, 2026
Merged

[codex] Surface public RSC performance demo#104
justin808 merged 2 commits into
mainfrom
jg-codex/rsc-demo-site-links

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented May 13, 2026

Summary

  • Adds prominent reactonrails.com links to the public RSC performance dashboard from the examples and Pro pages.
  • Adds the marketplace RSC demo repo to the examples repository list.
  • Commits the regenerated Docusaurus sidebar from the latest upstream docs sync.

Validation

  • npm run build:full passed.
  • npm --prefix prototypes/docusaurus run typecheck passed.
  • External link probe returned HTTP 200 for the RSC demo homepage, performance dashboard, Lighthouse pages, /why-rsc, and marketplace RSC demo repo.

Note: the Docusaurus build still reports existing unrelated broken link/anchor warnings in legacy/upstream docs; none are from the new RSC links.


Note

Low Risk
Low risk documentation-site updates that add new navigation items and external links; main risk is broken/changed external URLs or minor routing issues.

Overview
Surfaces a public React Server Components performance dashboard more prominently by adding a new evaluation card on examples and a new CTA/button plus comparison-row messaging on the pro page.

Expands the examples list with the public RSC marketplace demo repo, and updates the Docusaurus sidebar to include additional Getting Started/Migration/RSC-related docs entries.

Reviewed by Cursor Bugbot for commit 602ded3. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 37 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0aac62d8-2fb0-4881-bb26-01574936b3d0

📥 Commits

Reviewing files that changed from the base of the PR and between f14cc13 and 602ded3.

📒 Files selected for processing (3)
  • prototypes/docusaurus/sidebars.ts
  • prototypes/docusaurus/src/pages/examples.tsx
  • prototypes/docusaurus/src/pages/pro.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/rsc-demo-site-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4e23a09. Configure here.

Comment thread prototypes/docusaurus/src/pages/examples.tsx
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Cloudflare preview deployed.

@justin808 justin808 marked this pull request as ready for review May 13, 2026 08:06
@justin808 justin808 merged commit 51eefd6 into main May 13, 2026
4 checks passed
@justin808 justin808 deleted the jg-codex/rsc-demo-site-links branch May 13, 2026 08:06
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR surfaces the public RSC performance dashboard more prominently by adding a new evaluation card on the Examples page, a hero CTA button and feature-table row on the Pro page, and an inline footer link. It also registers the marketplace RSC demo repo in the examples list and regenerates the Docusaurus sidebar with several new doc entries.

  • examples.tsx: Introduces a discriminated-union EvaluationPath type to cleanly separate internal (to) from external (href) links; correctly migrates all existing internal routes from the old href property to to; adds the RSC benchmark card and the marketplace repo entry.
  • pro.tsx: Adds a "View RSC performance demo" hero button and a footer inline link both pointing to https://rsc.reactonrails.com/search-performance; the hero button uses Docusaurus Link (handles target/rel automatically), but the footer <a> tag does not set target=\"_blank\" or rel=\"noopener noreferrer\".
  • sidebars.ts: Appends four new doc IDs across Getting Started, Migration, and RSC subcategories; purely additive with no structural changes.

Confidence Score: 4/5

Safe to merge; changes are additive UI links and sidebar entries with no logic that could break existing behavior.

The Examples page correctly uses a discriminated union to route internal vs. external links, and the build is confirmed passing. The one inconsistency is that the new inline <a> tag in pro.tsx's footer note lacks target="_blank" and rel="noopener noreferrer", while the hero button added in the same PR uses Docusaurus Link which handles those attributes automatically — leaving the footer link to navigate users away from the page rather than opening a new tab.

prototypes/docusaurus/src/pages/pro.tsx — the inline <a> at the bottom of the feature comparison section should be checked for consistent external-link behavior.

Important Files Changed

Filename Overview
prototypes/docusaurus/sidebars.ts Adds four new sidebar doc entries across Getting Started, Migration, and RSC sections; no logic changes, build confirmed passing.
prototypes/docusaurus/src/pages/examples.tsx Introduces a discriminated union type to distinguish internal (to) from external (href) evaluation-path links; correctly migrates existing internal routes to use to; adds RSC demo card and marketplace repo entry.
prototypes/docusaurus/src/pages/pro.tsx Adds RSC demo hero button (uses Docusaurus Link with href — correct), a feature-table row, and an inline <a> link in the footer note; the inline <a> lacks target="_blank" / rel="noopener noreferrer" unlike the hero button above it.

Reviews (1): Last reviewed commit: "Use href for external RSC path card" | Re-trigger Greptile

Comment on lines +157 to +159
<a href="/docs/pro">the Pro docs landing page</a>. Want proof first?
Open the{' '}
<a href="https://rsc.reactonrails.com/search-performance">RSC performance dashboard</a>.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 External link opens in same tab

The plain <a> tag linking to the RSC performance dashboard uses no target or rel attribute, so it navigates the user away from the Pro page in the same tab. The Link component used for the hero button above correctly delegates external-link behavior to Docusaurus (which adds target="_blank" and rel="noopener noreferrer" for href props), but this inline <a> does not get the same treatment. Consider replacing it with Docusaurus's Link component or adding target="_blank" rel="noopener noreferrer" for consistent UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant