-
-
Notifications
You must be signed in to change notification settings - Fork 634
Add tests for React 16 to CI #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
59d93bd
to
c8f58d1
Compare
c8f58d1
to
4034118
Compare
gsub_file_content( | ||
"../package.json", | ||
"jest node_package/tests", | ||
'jest node_package/tests --testPathIgnorePatterns=\".*(RSC|stream|serverRenderReactComponent).*\"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this we can either:
- Include something like
#react18
in the description of these tests and filter them out; - Use https://www.npmjs.com/package/jest-runner-groups.
Any preference?
9251919
to
d44422d
Compare
d44422d
to
a824b57
Compare
Summary
Make sure we don't accidentally break React 16 support.
Closes #1679.
Pull Request checklist
[ ] Update documentation[ ] Update CHANGELOG fileThis change is