-
-
Notifications
You must be signed in to change notification settings - Fork 634
Enable Jest ESLint plugin with recommended config #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughA new Jest-specific configuration has been added to the ESLint settings to better support test files. The changes include importing the Jest plugin and adding a configuration block that applies to files matching Jest test patterns. In several test files, assertion methods have been updated from Changes
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
} | ||
expect(error.message).toMatch(/Could not find component/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoids conditional expect
(though expect.assertions
will catch the problem if there is no error too, we could just disable the rule here instead).
@@ -8,28 +8,22 @@ meta.content = testToken; | |||
document.head.appendChild(meta); | |||
|
|||
describe('authenticityToken', () => { | |||
expect.assertions(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-jest
bans these expect.assertions(...)
calls outside actual tests.
The ones in them are allowed but not actually useful, they are good in two cases:
- testing async logic with callbacks instead of
async
/await
; - conditional
expect
including intry
/catch
, also banned by the plugin.
fc64ba1
to
d687a6f
Compare
Summary
Include the Jest ESLint plugin and fix the tests accordingly.
Pull Request checklist
[ ] Update documentation[ ] Update CHANGELOG fileThis change is
Summary by CodeRabbit
eslint-plugin-jest
and an update totypescript-eslint
.