-
Notifications
You must be signed in to change notification settings - Fork 385
Feat: Trigger review-app workflow when '/deploy-review-app' is commented (basic implementation) #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes modify the GitHub Actions workflow for deploying a review app to the Control Plane. A new trigger is added for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/deploy-to-control-plane-review.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/deploy-to-control-plane-review.yml (2)
9-10
: Added trigger for issue comments.The workflow now triggers on
issue_comment
events, specifically for created and edited comments. This allows the workflow to respond to user interactions via comments.The code changes are approved.
19-19
: Conditional execution fordeploy-to-control-plane-staging
job.The job now includes a condition to check if the event is not an
issue_comment
or if the comment matches/deploy-review-app
and is associated with a pull request. This ensures that the deployment is only triggered under the defined circumstances.The code changes are approved.
A better implementation is added in #597
To test comment triggers, the event trigger should be on master in this workflow file first. This change should enable testing the changes in #597
source: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment
This change is
Summary by CodeRabbit