[Feature] use pytest for sgl-kernel #4697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshxs
requested review from
zhyncs,
ispobock,
HandH1998,
BBuf,
yizhang2077 and
merrymercy
as code owners
zhyncs
reviewed
Mar 23, 2025
sgl-kernel/tests/test_activation.py
Outdated
| @@ -36,4 +36,6 @@ def test_fused_gelu_mul(dim, batch_size, seq_len): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| pytest.main([__file__]) | |||
| import sys | |||
There was a problem hiding this comment.
QQ Why not use pytest.main([__file__])
There was a problem hiding this comment.
wanted the error code to propagate rather than zero if test fails in CI. Should I revert back to using only pytest.main([__file__])? @zhyncs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For: #4690
Modifications
test files in: https://github.com/sgl-project/sglang/tree/main/sgl-kernel/tests
Checklist