Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inappropriate lack of Optional type on OpenAI ChatCompletionRequest #4681

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

BroadbentJim
Copy link
Contributor

@BroadbentJim BroadbentJim commented Mar 22, 2025

Motivation

Clearly wrong on inspection and also wrong when referencing here:
https://platform.openai.com/docs/api-reference/chat/create#chat-create-response_format

Modifications

Fix small type on OpenAI Model

Checklist

@BroadbentJim BroadbentJim changed the title fix: Inappropriate lack of Optional type fix: Inappropriate lack of Optional type on OpenAI ChatCompletionRequest Mar 22, 2025
@BroadbentJim BroadbentJim force-pushed the types/openai-protocol branch from 2703e7f to dd23f9f Compare March 23, 2025 09:43
@merrymercy merrymercy merged commit 550586e into sgl-project:main Mar 28, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants