-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added status full loaded into FileData #1246
Merged
+84
−42
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1d004c2
Added FileData::Status::FullLoaded
KKQ-KKQ 1177796
Improved setting FilData::Status
KKQ-KKQ 18c7300
Improved status check in garbage collection process
KKQ-KKQ 5e9c18a
Fixed status check order in garbage collection process
KKQ-KKQ 5108c3b
Merge branch 'develop' into addedStatusFullLoaded
KKQ-KKQ b0b3467
FullyLoaded status becomes independent. Added GarbageCollecting status.
KKQ-KKQ d7f1d81
Improved check for garbage collection
KKQ-KKQ 795fe2e
Improved check in garbage collection
KKQ-KKQ 1563428
Fixed a error in garbage collection
KKQ-KKQ 3985fe7
Improved process for maxOffset in FilePool::setPreloadSize()
KKQ-KKQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,7 @@ struct FileInformation { | |
// Strict C++11 disallows member initialization if aggregate initialization is to be used... | ||
struct FileData | ||
{ | ||
enum class Status { Invalid, Preloaded, Streaming, Done }; | ||
enum class Status { Invalid, Preloaded, Streaming, Done, FullLoaded }; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's call this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might be better that we have a boolean fullyLoaded variable on FileData instead of adding it's status enum. |
||
FileData() = default; | ||
FileData(FileAudioBuffer preloaded, FileInformation info) | ||
: preloadedData(std::move(preloaded)), information(std::move(info)) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to make the
maxOffset
ininformation
auint32_t
. I don't recall why I put anint64_t
, maybe for full generality and to better support integer arithmetics since you tend to add or remove offsets around. Was there a reason for you to forceuint32_t
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I will fix this.