-
-
Notifications
You must be signed in to change notification settings - Fork 786
Add ability to create PKey from parameters #2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
33d55eb
to
6ec4f5e
Compare
ddfc4d6
to
d5a03e9
Compare
d5a03e9
to
a87b819
Compare
a87b819
to
5e26fd8
Compare
@alex, any chance you could take a look at this PR? |
So, I'm not interested in including ossl params anywhere in the public API, I think they're a giant mistake and I hope OpenSSL gets rid of them. I'd be ok:
But I'm not interested in any changes to the public APIs for this. |
After working with params API to get things working in a non-deprecated way, I completely agree with you! Regarding the comment about changes to the public APIs, there was a reason why I added the rust-openssl/openssl/src/lib.rs Lines 180 to 181 in 5e26fd8
I left the visibility of everything else in that mod as pub because I was lazy. I can change it all to pub(crate) if you want?Either way, I don't think I've changed the public API (and if I have, it was completely unintentional as I agree that the params stuff should be kept internal only). |
Increases the safety of the code and, imho, increases the readability. Additionally, removes the need for iter, lanes & memcost to be mutable.
Simplifies and safens the code
5e26fd8
to
a8cce0c
Compare
Work towards #2047 by adding ability to create PKeys from OSSL params.
As such:
EVP_PKEY_fromdata*
APIs to PkeyCtx.For Rsa, this means that
from_public_components
would look like this