Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSLContext methods and properties #83

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Add SSLContext methods and properties #83

merged 3 commits into from
Feb 20, 2023

Conversation

sethmlarson
Copy link
Owner

@sethmlarson sethmlarson commented Jan 22, 2023 •
edited
Loading

Part of #47

@sethmlarson sethmlarson requested a review from davisagli January 22, 2023 19:59
@sethmlarson sethmlarson force-pushed the sslcontext branch 3 times, most recently from e4379b4 to d92bc79 Compare January 25, 2023 03:38
@sethmlarson
Copy link
Owner Author

Pinging @davisagli since when we last spoke about this PR it was not yet green. Now this should be ready to review!

davisagli
davisagli approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethmlarson Looks all right to me.

Should we document the places where truststore's SSLContext doesn't have parity with the stdlib SSLContext (i.e. those NotImplemented methods)?

@sethmlarson
Copy link
Owner Author

Thanks @davisagli! I agree we'll have to document the parity differences. I'll capture that in the issue.

@sethmlarson sethmlarson merged commit 63dc9e1 into main Feb 20, 2023
@sethmlarson sethmlarson deleted the sslcontext branch February 20, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethmlarson @davisagli