-
Notifications
You must be signed in to change notification settings - Fork 7
Pro backend request/response glue code #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Doy-lee
wants to merge
75
commits into
session-foundation:dev
Choose a base branch
from
Doy-lee:doyle-pro-backend-polish
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the API and minimises the API surface with code interacting with it since the public key is already bundled with the secret. - Add helper function to derive keys from the original seed - Use _hex_u literals to simplify test construction code
Design of the interface should be accomodating not opionated. This also fixes a bug where the pro backend key wasn't been initialised yet in the C interface
Due to BT encoding using sort order to order keys. Version at top means we can conditionally handle version changes easily.
Was mistakenly removed, upon review of iOS code 1o1s are wrapped in an envelope.
…roup,comms} functions
With the new helper functions encrypt_and_wrap_for_{1o1,group,community} its clearer that this API only really should be called in these 3 circumstances. Making it a kitchen sink black boxes the whole process but seems to give people options (destinations) that are meaningless as they don't do anything but we imply they might. I think it's better to get rid of it and simplify the calling interface.
We assume that you are encrypting for the destination AND into the correct namespace. Encrypting for 1o1 as a caller has the intent that you want to "talk" to someone and in all cases this would have to be encrypted which is the most obvious outcome of what you would expect to get if you asked libsession to do it. The namespace complicated things unnecessarily by making it appear as if there's an alternative way to encrypt if you were targetting different namespace. Technically this is true, if you target another namesspace/mailbox there are different conventions on how an application should consume data from that mailbox but that is not related to the task of encrypting for a conversation (1o1, group, community, sync message).
f834337
to
e5862ab
Compare
410f0e7
to
a83ab26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes ontop of #63 only need to review the delta between the two.
--
The commits here are a polish pass over the draft code that was dumped into
src/pro.cpp
. That file has been renamed tosrc/pro_backend.cpp
. The role of this file now is to interop with the pro backend and adds a bunch of functions to construct the necessary HTTP POST payloads to send off to a Session Pro Backend to do one of the following operations:Additionally for each payment provider, libsession exposes the various platform specific URLs to centralise those strings into the same repository, as per:
The general usage pattern for the request and response code available in
pro_backend.{hpp,h}