Drop memory after releasing the global lock

src/atom.rs

@@ -237,7 +237,8 @@ impl<Static> Drop for Atom<Static> {
 
         // Out of line to guide inlining.
         fn drop_slow<Static>(this: &mut Atom<Static>) {
-            DYNAMIC_SET
+            // We temporarily store the string in the stack to drop after releasing the lock
+            let _removed = DYNAMIC_SET
                 .lock()
                 .remove(this.unsafe_data.get() as *mut Entry);
         }

src/dynamic_set.rs

@@ -85,7 +85,7 @@ impl Set {
         ptr
     }
 
-    pub(crate) fn remove(&mut self, ptr: *mut Entry) {
+    pub(crate) fn remove(&mut self, ptr: *mut Entry) -> Option<Box<Entry>> {
         let bucket_index = {
             let value: &Entry = unsafe { &*ptr };
             debug_assert!(value.ref_count.load(SeqCst) == 0);
@@ -97,12 +97,11 @@ impl Set {
         while let Some(entry_ptr) = current.as_mut() {
             let entry_ptr: *mut Entry = &mut **entry_ptr;
             if entry_ptr == ptr {
-                mem::drop(mem::replace(current, unsafe {
-                    (*entry_ptr).next_in_bucket.take()
-                }));
-                break;
+                return mem::replace(current, unsafe { (*entry_ptr).next_in_bucket.take() });
             }
             current = unsafe { &mut (*entry_ptr).next_in_bucket };
         }
+
+        None
     }
 }