Add count_ones, count_zeros methods #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
requested changes
Nov 17, 2019
|
|
||
| if self.is_inline() { | ||
| let mask = inline_ones(len); | ||
| (self.data & mask).count_ones() as usize |
There was a problem hiding this comment.
I'd prefer to return here and deindent the rest.
There was a problem hiding this comment.
Do you really need the & mask for this case? The other bits should always be zero.
There was a problem hiding this comment.
Ah, I lie, I recall that we use the last non-zero bit as a sentinel, so you do need this.
| (self.data & mask).count_ones() as usize | ||
| } else { | ||
| let mut count = 0; | ||
| for &storage in self.buffer() { |
There was a problem hiding this comment.
Same, can't this loop just do count += storage.count_ones()?
There was a problem hiding this comment.
And you cannot, because we don't clear storage when we pop(), so never mind :)
| } | ||
|
|
||
| /// Counts the number of bits in the vector that are set to zero/false | ||
| pub fn count_zeros(&self) -> usize { |
There was a problem hiding this comment.
Why can't this be self.len() - self.count_ones()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self-explanatory. Add methods for counting the number of ones/zeros in a
SmallBitVec.