Skip to content

Update devices no bluetooth (do not merge!) #11812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 21, 2016

@larsbergstrom, please have a look later.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 21, 2016
@highfive
Copy link

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@jdm jdm assigned larsbergstrom and unassigned nox Jun 21, 2016
@larsbergstrom
Copy link
Contributor

./mach build -d seems to succeed here.

So does ./mach build -d --no-default-features --features="glutin_app", and as far as I can tell it didn't build in bluetooth.

What error are you seeing / do you want help correcting with this branch?

@djc
Copy link
Contributor Author

djc commented Jun 21, 2016

It still seemed to build blurz for me, and error out linking it with dbus.

@larsbergstrom
Copy link
Contributor

Hrm, I was unable to get this working either. Hopefully after I get us onto cargo workspaces (#12391), this can be retried and will be easier? Sorry I sat on this for so long!

@larsbergstrom larsbergstrom added the S-needs-rebase There are merge conflict errors. label Aug 19, 2016
@jdm
Copy link
Member

jdm commented Sep 13, 2016

rust-lang/cargo#3024 (comment) suggests that more code changes are necessary here. Closing, since this appears to have a solution now.

@jdm jdm closed this Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants