-
Notifications
You must be signed in to change notification settings - Fork 354
Update tests to Unicode 16.0 #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And the tests here are, of course, failing, because the new versions of the dependencies haven't been published, yet. Also, once |
…apter on Rust 1.67
And, of course ICU4X 1.x doesn't work with Unicode 16.0 test data, so that can't be tested. |
And, indeed, there are enough changes that the old test suite does not pass with Unicode 16.0 implementation internals. |
Timings building
|
Updating from ICU4X 1.5 (Unicode 15.1) to 2.0 (Unicode 16.0) increases the Brotli-compressed wasm-opt-optimized wasm footprint of |
ICU4X 1.5:
ICU4X 2.0:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage ? 80.11%
=======================================
Files ? 24
Lines ? 4355
Branches ? 0
=======================================
Hits ? 3489
Misses ? 866
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps url from 2.5.4 to 2.5.5. Release notes Sourced from url's releases. v2.5.5 What's Changed ci: downgrade crates when building for Rust 1.67.0 by @mxinden in servo/rust-url#1003 ci: run unit tests with sanitizers by @mxinden in servo/rust-url#1002 fix small typo by @hkBst in servo/rust-url#1011 chore: fix clippy errors on main by @dsherret in servo/rust-url#1019 perf: remove heap allocation in parse_query by @dsherret in servo/rust-url#1020 perf: slightly improve parsing a port by @dsherret in servo/rust-url#1022 perf: improve to_file_path() by @dsherret in servo/rust-url#1018 perf: make parse_scheme slightly faster by @dsherret in servo/rust-url#1025 update LICENSE-MIT by @wmjae in servo/rust-url#1029 perf: url encode path segments in longer string slices by @dsherret in servo/rust-url#1026 Disable the default features on serde by @rilipco in servo/rust-url#1033 docs: base url relative join by @tisonkun in servo/rust-url#1013 perf: remove heap allocation in parse_host by @dsherret in servo/rust-url#1021 Update tests to Unicode 16.0 by @hsivonen in servo/rust-url#1045 Add some some basic functions to Mime by @mrobinson in servo/rust-url#1047 ran cargo clippy --fix -- -Wclippy::use_self by @mrobinson in servo/rust-url#1048 Fix MSRV and clippy CI by @Manishearth in servo/rust-url#1058 Update Url::domain docs to show that it includes subdomain by @supercoolspy in servo/rust-url#1057 set_hostname should error when encountering colon ':' by @edgul in servo/rust-url#1060 version bump to 2.5.5 by @edgul in servo/rust-url#1061 New Contributors @mxinden made their first contribution in servo/rust-url#1003 @hkBst made their first contribution in servo/rust-url#1011 @wmjae made their first contribution in servo/rust-url#1029 @rilipco made their first contribution in servo/rust-url#1033 @tisonkun made their first contribution in servo/rust-url#1013 @supercoolspy made their first contribution in servo/rust-url#1057 Full Changelog: servo/[email protected] Commits a40f904 version bump to 2.5.5 (#1061) cf305db set_hostname should error when encountering colon ':' (#1060) 88826bd Update Url::domain docs to show that it includes subdomain (#1057) c3bbf66 Fix MSRV and clippy CI (#1058) dbd5261 ran cargo clippy --fix -- -Wclippy::use_self (#1048) 9f6e92e Add some some basic functions to Mime (#1047) 68f151c Update tests to Unicode 16.0 (#1045) 7cff874 perf: remove heap allocation in parse_host (#1021) 968e862 docs: base url relative join (#1013) 2ce2e12 Disable the default features on serde. (#1033) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This updates the tests to Unicode 16.0. The test harness needs changes, because the earlier test suite had a bug concerning trailing dots. Now the test suite matches the spec text, but the deprecated
idna
API retains the behavior that was written to the old test suite bug.It is somewhat unfortunate the test suite is in this repo, but whether the code performs Unicode 16.0 behavior is up to the dependencies. Therefore, the expected landing sequence is this:
idna_adapter
1.2.1 from itsmain
branch.idna_mapping
1.1.0 from itsmain
branch.