Skip to content

Revert "Copy all the sources to OUT_DIR before building them" #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdm
Copy link
Member

@jdm jdm commented Jan 10, 2020

This reverts commit 1d588b2 and fixes #218.

@jdm
Copy link
Member Author

jdm commented Jan 13, 2020

r? @nox

@nox
Copy link
Contributor

nox commented Jan 13, 2020

Is this really important to land? It's included in my smup without losing the things that we should keep from this commit.

@jdm
Copy link
Member Author

jdm commented Jan 13, 2020

It prevents 332d090 and #219 from being used by Servo master right now. I would prefer not to leave this repository in its unusable state longer than necessary.

@nox
Copy link
Contributor

nox commented Jan 14, 2020

Superseded by #227.

@nox nox closed this Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build fails during source file copying phase
2 participants