Skip to content

Windows build fails during source file copying phase #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdm opened this issue Dec 18, 2019 · 5 comments
Closed

Windows build fails during source file copying phase #218

jdm opened this issue Dec 18, 2019 · 5 comments
Labels

Comments

@jdm
Copy link
Member

jdm commented Dec 18, 2019

I get a panic in

mozjs/build.rs

Line 407 in 618398c

fs::copy(&source, &target).expect("could not copy file");
after modifying makefile.cargo and rebuilding.

@jdm jdm added the windows label Dec 18, 2019
@jdm
Copy link
Member Author

jdm commented Dec 18, 2019

I think we're hitting some kind of path limit:
This works - copying "mozjs\\js\\src\\tests\\test262\\language\\block-scope\\syntax\\redeclaration\\fn-scope-var-name-redeclaration-attempt-with-var.js" to "C:\\Users\\image\\servo-g-streamer\\target\\x86_64-uwp-windows-msvc\\release\\build\\mozjs_sys-a12625fb54d6148d\\out\\mozjs\\js\\src\\tests\\test262\\language\\block-scope\\syntax\\redeclaration\\fn-scope-var-name-redeclaration-attempt-with-var.js"
This fails - copying "mozjs\\js\\src\\tests\\test262\\language\\block-scope\\syntax\\redeclaration\\function-declaration-attempt-to-redeclare-with-var-declaration-nested-in-function.js" to "C:\\Users\\image\\servo-g-streamer\\target\\x86_64-uwp-windows-msvc\\release\\build\\mozjs_sys-a12625fb54d6148d\\out\\mozjs\\js\\src\\tests\\test262\\language\\block-scope\\syntax\\redeclaration\\function-declaration-attempt-to-redeclare-with-var-declaration-nested-in-function.js"

@jdm
Copy link
Member Author

jdm commented Dec 18, 2019

thread 'main' panicked at 'could not copy file: Os { code: 3, kind: NotFound, message: "The system cannot find the path specified." }', src\libcore\result.rs:1189:5

@jdm
Copy link
Member Author

jdm commented Dec 18, 2019

I made progress by prepending \\?\ to the destination path before the copying, then replacing that string in the src and build directory paths before invoking configure. However, then things broke inside the python configuration process that didn't make sense to me and I gave up and reverted to an earlier working version of this repo.

@jdm
Copy link
Member Author

jdm commented Jan 6, 2020

rust-lang/rust#67403
<nox> jdm: Feel free to revert. My automated vendoring stuff properly avoid generating .pyc files and does not build psutil at all.

@jdm
Copy link
Member Author

jdm commented Jan 6, 2020

#209 is the triggering PR.

nox added a commit that referenced this issue Jan 12, 2020
This messes things up on Windows. :(
nox added a commit that referenced this issue Jan 12, 2020
This messes things up on Windows. :(
nox added a commit that referenced this issue Jan 13, 2020
This messes things up on Windows. :(
nox added a commit that referenced this issue Jan 13, 2020
This messes things up on Windows. :(
nox added a commit that referenced this issue Jan 14, 2020
This messes things up on Windows. :(
bors-servo pushed a commit that referenced this issue Jan 14, 2020
 Don't copy sources in OUT_DIR anymore (fixes #218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant