Repository navigation
Add support for processing instructions - #790
Delta-official wants to merge 18 commits into
Conversation
mrobinson
left a comment
There was a problem hiding this comment.
A few comments here:
- Did you run tests for this change?
- Have you tested serialization? How does a processing instruction like
<?one two?>serialize? - It looks like you are only adding support for processing instructions in two insertion modes? The specification lists that they should be handled in many more (for instance in tables: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-intable).
Yes. Some are failing (see below) but it's a result of html5lib-tests being outdated Failing cases
Forgot about serialization, gonna add tests cases for that.
Missed those. Mainly went by warnings to see what was broken since this is my first time contributing and the other modes had default branches |
…gInstructionTarget`
…ocessing-instruction-target`
mrobinson
left a comment
There was a problem hiding this comment.
Looking better though I have a few minor comments. In addition you are still emitting the "bad char" error when the spec says to emit other kinds of parse errors.
The rest of the tokenizer code uses |
mrobinson
left a comment
There was a problem hiding this comment.
This one is getting close. Just a few minor things remaining:
|
@Delta-official Before this lands you will need to fix |
|
@mrobinson The current |
… example and tests
Adds support for processing instructions in
html5everand changes tests to supportProcessingInstructiontokens (see: html5lib/html5lib-tests#199)Fixes #789