Add StyleAtom to web_atoms
#661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
StyleAtomatom type containing the same strings as theAtomtype from stylo_atoms. The aim being to deprecate thestylo_atomscrate and replace it withweb_atoms. It is IMO easier to maintain here as we don't have to maintain a diff with upstream in this repo, and Stylo depends onweb_atomsanyway).If there are concerns around binary size for users of
htm5everthat are not usingStyleAtomtype then we could feature flag it, but I would be inclined not to worry about it too much for now.