Don't clone input buffer inside html5ever benchmark loop #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
mrobinson
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clone operation should not be counted towards the benchmark time. When the benchmark was written criterion did not support per-iteration setup, but now it does using
Bencher::iter_batched. Using this method reduces the benchmark time by 9% inlipsum.html.Additionally, the way html5ever was used inside the benchmarks was wrong if there were
<script>elements in the input.To fully tokenize input in html5ever, you need to spin on the
Tokenizer::feedmethod until it returnsDone.None of our benchmarks contain any script elements, but it's better to fix it anyways.