Skip to content

Don't import xml5ever enums into the global namespace #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

Don't import xml5ever enums into the global namespace #597

merged 1 commit into from
Apr 12, 2025

Conversation

simonwuelker
Copy link
Contributor

This is mostly the same as #593 but for xml5ever.

@simonwuelker
Copy link
Contributor Author

CI needs #596 first

mrobinson
mrobinson approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the great work moving html5ever toward modern Rust!

@simonwuelker
Don't import xml5ever enums into the global namespace
70a3e04 
This is mostly the same as servo#593 but for xml5ever.

Signed-off-by: Simon Wülker <[email protected]>
@simonwuelker simonwuelker added this pull request to the merge queue Apr 12, 2025
Merged via the queue into servo:main with commit cb63d4f Apr 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonwuelker @mrobinson