Skip to content

Don't use SSE4.1 instructions unless the target supports it #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

nical
Copy link
Contributor

@nical nical commented Jan 17, 2018

This is a rebase of #140.

Fixes #140, fixes #48.


This change is Reviewable

Fixes servo#48.

Enabling the SIMD code path now requires building with
`RUSTFLAGS="-C target-feature=+sse4.1"` or similar.
@nical
Copy link
Contributor Author

nical commented Jan 17, 2018

r? @SimonSapin

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 437bb8c has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 437bb8c with merge ec9148a...

bors-servo pushed a commit that referenced this pull request Jan 17, 2018
Don't use SSE4.1 instructions unless the target supports it

This is a rebase of #140.

Fixes #140, fixes #48.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/263)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing ec9148a to master...

@bors-servo bors-servo merged commit 437bb8c into servo:master Jan 18, 2018
@nical nical deleted the sse4 branch January 18, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make check is failing with "Illegal instruction"
4 participants