Fix correlation handling #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts as the input of the workflow instance to create when the òutcome` has been set to instantiate Signed-off-by: Charles d'Avernas <[email protected]>
…handled correlation contexts from the `WorkflowInstance` they are associated to fix(Runner): Fixed the `ConnectedWorkflowExecutionContext` to populate `WorkfowInstance` correlation keys set by handled correlation contexts fix(Runner): Fixed a feature-breaking bug with the `AsyncApiCallExecutor` disposing inline of the IAsyncApiSubscribeOperationResult, thus irreversibly breaking the message stream fix(Runner): Fixed the `AsyncApiCallExecutor`, which was not properly evaluating `while` and `until` message consumption conditions fix(Runner): Fixed the `AsyncApiCallExecutor`, which was not passing the `item` and `index` arguments to the `output.as` and `export.as` expressions Signed-off-by: Charles d'Avernas <[email protected]>
cdavernas
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
ConnectedWorkflowExecutionContextto remove handled correlation contexts from theWorkflowInstancethey are associated toConnectedWorkflowExecutionContextto populateWorkfowInstancecorrelation keys set by handled correlation contextsAsyncApiCallExecutordisposing inline of the IAsyncApiSubscribeOperationResult, thus irreversibly breaking the message streamAsyncApiCallExecutor, which was not properly evaluatingwhileanduntilmessage consumption conditionsAsyncApiCallExecutor, which was not passing theitemandindexarguments to theoutput.asandexport.asexpressions