Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handled if clauses the Dashboard's graph builder #468

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Refactors the way the graph is built to handle if clauses. Entry and exit ports have been added to cluster nodes to facilitate conditional "branching" and "rejoining".

Closes #409

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
- Fixed logging messages format in the graph builder

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi added type: bug Something isn't working app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue weight: 2 An issue with a low development impact labels Dec 12, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Dec 12, 2024
@JBBianchi JBBianchi requested a review from cdavernas December 12, 2024 15:31
@JBBianchi JBBianchi self-assigned this Dec 12, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!!

@cdavernas cdavernas merged commit f532e8a into main Dec 12, 2024
2 checks passed
@cdavernas cdavernas deleted the fix-refactor-conditional-nodes branch December 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: bug Something isn't working weight: 2 An issue with a low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Invalid handling of if in the dashboard graph
2 participants