-
Notifications
You must be signed in to change notification settings - Fork 166
feat: add a new mcp call #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new mcp call #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Model Context Protocol (MCP) calls to the workflow specification, enabling workflows to interact with MCP servers through HTTP or STDIO transports.
- Introduces a new
CallMCPtask type with protocol version, method, parameters, timeout, transport, and client configuration - Adds comprehensive documentation for MCP calls, transports (HTTP and STDIO), and client configuration
- Provides example implementations demonstrating MCP integration with Slack
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| schema/workflow.yaml | Defines the schema for the new MCP call task type including transport options and client configuration |
| dsl-reference.md | Documents the MCP call feature with usage examples and describes HTTP/STDIO transport configurations |
Comments suppressed due to low confidence (1)
dsl-reference.md:1
- Corrected spelling of 'sttring' to 'string'.
# Serverless Workflow DSL - Reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Charles d'Avernas <[email protected]>
Signed-off-by: Charles d'Avernas <[email protected]>
Signed-off-by: Charles d'Avernas <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Charles d'Avernas <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Charles d'Avernas <[email protected]>
7903641 to
23a814c
Compare
Signed-off-by: Charles d'Avernas <[email protected]>
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
Additional information:
Thanks to @amin-nikanjam for his earlier PR attempt, which served as the foundation for this one.
For schema validation reasons, it turned out to be simpler to restart from scratch rather than build on top of his implementation.