-
Notifications
You must be signed in to change notification settings - Fork 166
[Fix #1119] Allowing runtime xpression for duration #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Great catch! Thank you man ❤️!
@fjtirado Maybe you could update the |
@fjtirado I think the force push blocked the merge. Can you provide the fix @cdavernas mentioned with a signed commit, so then we can verify if it will work ok. ![]() |
@ricardozanini The force push was to add the DCO ;). |
@cdavernas is the merge button blocked for you too? |
Signed-off-by: fjtirado <[email protected]>
@ricardozanini commit signed (it was not easy) |
Now it's working, what did you do? Was a GPG thing? |
Yes, I did not have GPG setup locally. |
Please specify parts of this PR update:
Discussion or Issue link:
Fix #1119
What this PR does:
Change the schema to allow runtime expression for durations
Additional information: