Skip to content

Conversation

fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Oct 21, 2025

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Fix #1119

What this PR does:

Change the schema to allow runtime expression for durations

Additional information:

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Great catch! Thank you man ❤️!

@cdavernas
Copy link
Member

@fjtirado Maybe you could update the spec.md file to indicate expression support for durations?

@ricardozanini
Copy link
Member

@fjtirado I think the force push blocked the merge. Can you provide the fix @cdavernas mentioned with a signed commit, so then we can verify if it will work ok.

Screenshot 2025-10-21 at 10 00 13 AM

@fjtirado
Copy link
Collaborator Author

@ricardozanini The force push was to add the DCO ;).

@ricardozanini
Copy link
Member

@cdavernas is the merge button blocked for you too?

@fjtirado
Copy link
Collaborator Author

@ricardozanini commit signed (it was not easy)

@cdavernas
Copy link
Member

@ricardozanini No

@ricardozanini
Copy link
Member

@ricardozanini commit signed (it was not easy)

Now it's working, what did you do? Was a GPG thing?

@ricardozanini ricardozanini merged commit 833d25d into serverlessworkflow:main Oct 21, 2025
3 checks passed
@fjtirado
Copy link
Collaborator Author

@ricardozanini commit signed (it was not easy)

Now it's working, what did you do? Was a GPG thing?

Yes, I did not have GPG setup locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow runtime expression to generate duration

3 participants