Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-alpha #188

Merged
merged 24 commits into from
Jan 13, 2025
Merged

v1.0.0-alpha #188

merged 24 commits into from
Jan 13, 2025

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Support for v1.0.0-alpha (#186)

Special notes for reviewers:
Type generation for schema is very unstable, a small change in the spec can have a big impact on the generated types and underlying validators, classes and builders.
Classes are empty. It's just a trick to maybe have some kind of runtime type checking (see builders tests).

Additional information (if needed):
Currently uses a manually modified version of the spec's JSON Schema. Yield completely different results otherwise.

JBBianchi added 11 commits July 24, 2024 19:22
- changed organisation and package name
- updated maintainers
- removed previous code items
- updated tools

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi
Copy link
Member Author

JBBianchi commented Jul 31, 2024

I think the branch reached a mature enough state for code review.

The README has been updated to match the new API and I added a Tooling Architecture document to describe how the SDK is built.

Any input or help is welcome ❤️
@antmendoza @matthias-pichler @zolero @AtomicJon @ghuntley @SrWildman

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Prevents accessing a property which is declared in one type but not the other:
```
type A = { p: string; }; type B = { k: number; };
const foo = {} as A | B;
foo.p = "bar";
//>Property 'p' does not exist on type 'A | B'.
//>  Property 'p' does not exist on type 'B'.
```

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
…t in the tooling

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Allows to validate an item against the workflow, for instance a transition, the use of a a function, ...

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@chakrabar
Copy link

Hello. Is there any plan to merge it and have a newer version of the TS SDK released supporting spec version 1.0.0.?

@JBBianchi
Copy link
Member Author

@chakrabar Thank you for your interest! Yes, there are plans to move forward, but we don't have a definitive timeline at the moment. Ideally, we’d like to enhance the unit tests and add some examples to ensure a solid foundation. I'll do my best to make progress in the coming days, depending on my availability. In the meantime, please feel free to contribute if you'd like to tackle any tasks—we’d greatly appreciate your help!

- Readded browser and node examples
- Added call async api/grpc/function tests

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
- Fixed the builders output type
- Added more samples

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi marked this pull request as ready for review January 13, 2025 13:56
@JBBianchi JBBianchi requested a review from cdavernas January 13, 2025 13:57
@JBBianchi JBBianchi self-assigned this Jan 13, 2025
@JBBianchi JBBianchi added the enhancement New feature or request label Jan 13, 2025
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Cheers ❤️

@cdavernas cdavernas merged commit 0fa8f89 into serverlessworkflow:main Jan 13, 2025
4 checks passed
@cdavernas cdavernas deleted the v1.0.0-alpha branch January 13, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants