Add RunTask.shell task

[mcruzdev]

Context

Implement RunTask.shell task:

document:
  dsl: '1.0.1'
  namespace: test
  name: run-shell-example
  version: '0.1.0'
do:
  - runShell:
      run:
        shell:
          command: 'echo "Hello, ${ .user.name }"'

Tracking

• Add arguments
• Implement await
• Implement return
• Support multiple OS
  

Closes #892

[mcruzdev]

@ricardozanini could you share with me a example of arguments? Should be something similar to:

document:
  dsl: '1.0.1'
  namespace: test
  name: run-shell-example
  version: '0.1.0'
do:
  - runShell:
      run:
        shell:
          command: 'kubectl'
          arguments:
            - 'apply'
            - '-f'
            - '/k8s'

And the output should be:

kubectl apply -f /k8s

I am assuming that arguments is a list.

[fjtirado]

@mcruzdev This has to wait to #899, then you can rebase and move forward

[fjtirado]

@mcruzdev I have merged #900, please rebase and continue from there, thanks

[mcruzdev]

Great @fjtirado, nice abstractions ;)

[ricardozanini]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process

Which kind of example do you need?

[mcruzdev]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process

Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄

I had a confusion due to map as type of arguments in the documentation.

[ricardozanini]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process
Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄

I had a confusion due to map as type of arguments in the documentation.

You can do:

arguments:
  - key: value

Maybe in some use cases that would make sense.

[mcruzdev]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process
Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄
I had a confusion due to map as type of arguments in the documentation.

You can do:

arguments:
  - key: value

Maybe in some use cases that would make sense.

It is not clear to me again @ricardozanini, what is the real command statement in that case? The arguments will be used like an input (like script does)? Or we will have something like customcommand key=value or customcommand key=value in the statement.

[fjtirado]

Althour the override of outputstream is quite imaginative and I like it, I have to mention that is better to use standard library, using

StringWriter outWriter = new StringWriter();
process.getInputStream().transferTo(new OutputStreamWriter(outWriter));

.....

outWriter.toString();

[mcruzdev]

I think that the OutputStreamWriter is not possible, but yes, we need a better solution that is not a byte to byte.

EDIT: I mean in the transferTo method.

[fjtirado]

Great work!
Just minor comments, except the error one.