[4.x] Fix #603 - Add guard code to collections, tidy up Workflow serializer #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fix #603
What this PR does / why we need it:
Special notes for reviewers:
@fjtirado I've made a "breaking" change. Previously, the
Workflow.toJson()
methods would swallow all exceptions, logging them to the console. Since the API did not come with an SLF4J implementation, the message will not be displayed, and the exception will be lost forever.Instead, we now throw an
IllegalException
to fail fast and avoid forcing client code to catch exceptions.@gmunozfe, mind taking a look too? Perhaps we can give it a try with Kogito and assess this change impact.
Additional information (if needed):