Skip to content

[Fix #844] Allow disable life cycle events per publisher #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fjtirado wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix #844] Allow disable life cycle events per publisher #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions impl/core/src/main/java/io/serverlessworkflow/impl/events/EventPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,9 @@

public interface EventPublisher extends AutoCloseable {
CompletableFuture<Void> publish(CloudEvent event);

/*If published decide to ignore life cycle events, override this method and leave it empty*/
default void publishLifeCycle(CloudEvent event) {
publish(event);
}
}
2 changes: 1 addition & 1 deletion ...ore/src/main/java/io/serverlessworkflow/impl/lifecycle/ce/AbstractLifeCyclePublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ protected <T extends WorkflowEvent> void publish(T ev, Function<T, CloudEvent> c
* using application event publishers. That might be changed if needed by children by overriding this method
*/
protected void publish(WorkflowApplication application, CloudEvent ce) {
application.eventPublishers().forEach(p -> p.publish(ce));
application.eventPublishers().forEach(p -> p.publishLifeCycle(ce));
}

private static <T> CloudEventData cloudEventData(T data, ToBytes<T> toBytes) {
Expand Down