IterationParam made optional as per version V.8.0 of specification

Signed-off-by: manick02 <[email protected]>

Author: manick02

validation/src/main/java/io/serverlessworkflow/validation/WorkflowValidatorImpl.java

@@ -319,13 +319,6 @@ public List<ValidationError> validate() {
                           "ForEach state should have a valid inputCollection",
                           ValidationError.WORKFLOW_VALIDATION);
                     }
-
-                    if (forEachState.getIterationParam() == null
-                        || forEachState.getIterationParam().isEmpty()) {
-                      addValidationError(
-                          "ForEach state should have a valid iteration parameter",
-                          ValidationError.WORKFLOW_VALIDATION);
-                    }
                   }
 
                   if (s instanceof CallbackState) {

validation/src/test/java/io/serverlessworkflow/validation/test/WorkflowValidationTest.java

@@ -146,7 +146,7 @@ public void testOperationStateNoFunctionRef() {
   }
 
   @Test
-  public void testValidatateWorkflowWithNoStartStateandNameSpecified() {
+  public void testValidatateWorkflowForOptionalStartStateAndWorkflowName() {
     Workflow workflow =
         new Workflow()
             .withId("test-workflow")
@@ -164,4 +164,51 @@ public void testValidatateWorkflowWithNoStartStateandNameSpecified() {
     Assertions.assertNotNull(validationErrors);
     Assertions.assertEquals(0, validationErrors.size());
   }
+
+  @Test
+  public void testValidateWorkflowForOptionalIterationParam() {
+    WorkflowValidator workflowValidator = new WorkflowValidatorImpl();
+    List<ValidationError> validationErrors =
+        workflowValidator
+            .setSource(
+                "{\n"
+                    + "\"id\": \"checkInbox\",\n"
+                    + "  \"name\": \"Check Inbox Workflow\",\n"
+                    + "\"description\": \"Periodically Check Inbox\",\n"
+                    + "\"version\": \"1.0\",\n"
+                    + "\"start\": \"CheckInbox\",\n"
+                    + "\"functions\": [\n"
+                    + "\n"
+                    + "],\n"
+                    + "\"states\": [\n"
+                    + "    {\n"
+                    + "        \"name\": \"CheckInbox\",\n"
+                    + "        \"type\": \"operation\",\n"
+                    + "        \"actionMode\": \"sequential\",\n"
+                    + "        \"actions\": [\n"
+                    + "            {\n"
+                    + "                \"functionRef\": {\n"
+                    + "                    \"refName\": \"checkInboxFunction\"\n"
+                    + "                }\n"
+                    + "            }\n"
+                    + "        ],\n"
+                    + "        \"transition\": {\n"
+                    + "            \"nextState\": \"SendTextForHighPrioriry\"\n"
+                    + "        }\n"
+                    + "    },\n"
+                    + "    {\n"
+                    + "        \"name\": \"SendTextForHighPrioriry\",\n"
+                    + "        \"type\": \"foreach\",\n"
+                    + "        \"inputCollection\": \"${ .message }\",\n"
+                    + "        \"end\": {\n"
+                    + "            \"kind\": \"default\"\n"
+                    + "        }\n"
+                    + "    }\n"
+                    + "]\n"
+                    + "}")
+            .validate();
+
+    Assertions.assertNotNull(validationErrors);
+    Assertions.assertEquals(1, validationErrors.size()); // validation error raised for functionref not for iterationParam
+  }
 }