Removing workflow name and startstart mandatory checks as they become optional from spec version 0.8

Signed-off-by: manick02 <[email protected]>

Author: manick02

validation/src/main/java/io/serverlessworkflow/validation/WorkflowValidatorImpl.java

@@ -116,16 +116,6 @@ public List<ValidationError> validate() {
         addValidationError("Workflow id should not be empty", ValidationError.WORKFLOW_VALIDATION);
       }
 
-      if (workflow.getName() == null || workflow.getName().trim().isEmpty()) {
-        addValidationError(
-            "Workflow name should not be empty", ValidationError.WORKFLOW_VALIDATION);
-      }
-
-      if (workflow.getStart() == null) {
-        addValidationError(
-            "Workflow must define a starting state", ValidationError.WORKFLOW_VALIDATION);
-      }
-
       if (workflow.getVersion() == null || workflow.getVersion().trim().isEmpty()) {
         addValidationError(
             "Workflow version should not be empty", ValidationError.WORKFLOW_VALIDATION);
@@ -137,12 +127,16 @@ public List<ValidationError> validate() {
 
       if (workflow.getStates() != null && !workflow.getStates().isEmpty()) {
         boolean existingStateWithStartProperty = false;
-        String startProperty = workflow.getStart().getStateName();
-        for (State s : workflow.getStates()) {
-          if (s.getName().equals(startProperty)) {
-            existingStateWithStartProperty = true;
-            break;
+        if (workflow.getStart() != null) {
+          String startProperty = workflow.getStart().getStateName();
+          for (State s : workflow.getStates()) {
+            if (s.getName().equals(startProperty)) {
+              existingStateWithStartProperty = true;
+              break;
+            }
           }
+        } else {
+          existingStateWithStartProperty = true;
         }
         if (!existingStateWithStartProperty) {
           addValidationError(

validation/src/test/java/io/serverlessworkflow/validation/test/WorkflowValidationTest.java

@@ -67,13 +67,10 @@ public void testFromIncompleteWorkflow() {
     WorkflowValidator workflowValidator = new WorkflowValidatorImpl();
     List<ValidationError> validationErrors = workflowValidator.setWorkflow(workflow).validate();
     Assertions.assertNotNull(validationErrors);
-    Assertions.assertEquals(2, validationErrors.size());
-
-    Assertions.assertEquals(
-        "Workflow name should not be empty", validationErrors.get(0).getMessage());
+    Assertions.assertEquals(1, validationErrors.size());
     Assertions.assertEquals(
         "No state name found that matches the workflow start definition",
-        validationErrors.get(1).getMessage());
+        validationErrors.get(0).getMessage());
   }
 
   @Test
@@ -147,4 +144,24 @@ public void testOperationStateNoFunctionRef() {
         "Operation State action functionRef does not reference an existing workflow function definition",
         validationErrors.get(0).getMessage());
   }
+
+  @Test
+  public void testValidatateWorkflowWithNoStartStateandNameSpecified() {
+    Workflow workflow =
+        new Workflow()
+            .withId("test-workflow")
+            .withVersion("1.0")
+            .withStates(
+                Arrays.asList(
+                    new SleepState()
+                        .withName("sleepState")
+                        .withType(SLEEP)
+                        .withEnd(new End())
+                        .withDuration("PT1M")));
+
+    WorkflowValidator workflowValidator = new WorkflowValidatorImpl();
+    List<ValidationError> validationErrors = workflowValidator.setWorkflow(workflow).validate();
+    Assertions.assertNotNull(validationErrors);
+    Assertions.assertEquals(0, validationErrors.size());
+  }
 }