Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dependencies, tests, and clean code #35
base: master
Are you sure you want to change the base?
fix dependencies, tests, and clean code #35
Changes from 1 commit
f5766f3
d679471
cd5d28c
deb7d98
d7df61f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why dependencies are downgraded?
Are those packages not respecting semver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typescript
doesn't at the least. You were getting a build error because the versions are out of sync with each other.If we think we need to have the newer version then we should make a v2 that uses latest packages and node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply followed semever and updated packages in version range that should not introduce breaking changes.
Majority of packages on npm follow semver, so it was pretty natural move, that normally works. It's kind of surprising it isn't here.
Therefore if you're sure that some of the bumped packages do not follow semver please fix them to a specific version, but rest should be safe with
^
versioningThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@medikoo I have packages updated where it will build with the newest.